IMAGE_REF result from image building Tasks
#1111
Conversation
|
Is the intention of this to make it easier for users to onboard to a multi-arch flow or just to simplify the interface? If the former, then this process can also be simplified when we create a dedicated multi-arch Tekton Pipeline. The yaml files pushed out can look something similar to what I am using here for example: https://github.com/konflux-ci/buildah-container/pull/9/files. |
|
@arewm the intention here is to enable the use of matrix feature which reduces the complexity of a multi-arch Pipeline definition. This was already presented on the May 30th demo call, you can lookup the recording. |
zregvart
force-pushed
the
issue/EC-654-alt
branch
from
8435f72 to
2b6bbba
Compare
|
Keeping this in draft until we get to STONEBLD-2326 |
|
I just ran into an issue related to this. For the OLM konflux sample, I cannot "prepare" all architectures to run and then only enable the ones that I need with the current form. As long as I explicitly include all of the previous tasks in the parameters, the index image generation will be skipped if any of the results are empty. Changing to this pattern will enable a more user-friendly flow. |
Since the `build-image-index` depends on the results from each of the architecture-specific builds, the task (and all resulting dependant tasks) will be skipped if any of these are absent. Using the intended workflow of enabling users to specify the architectures to run with PipelineRun params will require this model to change. The PR konflux-ci/build-definitions#1111 is a potentially promising way to resolve this issue. Signed-off-by: arewm <[email protected]>
Since the `build-image-index` depends on the results from each of the architecture-specific builds, the task (and all resulting dependant tasks) will be skipped if any of these are absent. Using the intended workflow of enabling users to specify the architectures to run with PipelineRun params will require this model to change. The PR konflux-ci/build-definitions#1111 is a potentially promising way to resolve this issue. Signed-off-by: arewm <[email protected]>
zregvart
force-pushed
the
issue/EC-654-alt
branch
from
2b6bbba to
52d2f65
Compare
|
Rebased on buildah 0.2 changes, should be ready for another round of reviews now. |
zregvart
force-pushed
the
issue/EC-654-alt
branch
4 times, most recently
from
52d4145 to
f5049e7
Compare
This helps in the reuse of the results when using matrix feature of
Tekton. Given that the concatenation of two results from matrix-spawned
Tasks is not supported, e.g.
$(tasks.build-container-multiarch.results.IMAGE_URL[*])@$(tasks.build-container-multiarch.results.IMAGE_DIGEST[*])
will not expand correctly.
This produces the image reference in full in the `IMAGE_REF` result, so
the result from the matrix-spawned Tasks can be referenced using:
$(tasks.build-container-multiarch.results.IMAGE_REF[*])
Reference: https://issues.redhat.com/browse/EC-654
zregvart
force-pushed
the
issue/EC-654-alt
branch
from
f5049e7 to
e6a341c
Compare
|
/retest |
|
@zregvart, were you intending to change the generation of the image index in this PR as well or will that be up to users to change in their own pipelines? |
I think this is entirely up to the users and out of scope of this PR. If we had a multi-arch template pipeline then I would update that to use the new results. Follow EC-714 for more on that. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This helps in the reuse of the results when using matrix feature of Tekton. Given that the concatenation of two results from matrix-spawned Tasks is not supported, e.g.
will not expand correctly.
This produces the image reference in full in the
IMAGE_REFresult, so the result from the matrix-spawned Tasks can be referenced using:Reference: https://issues.redhat.com/browse/EC-654
Before you complete this pull request ...
Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.